pci: report NUMA node locality for the PCI devices #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Implicitely) depends on #224 |
ffromani
force-pushed
the
pci-expose-numa-node
branch
from
f11d823 to
783de03
Compare
jaypipes
approved these changes
Feb 23, 2021
pkg/pci/pci.go
Outdated
| @@ -39,6 +40,9 @@ type Device struct { | |||
| Subclass *pcidb.Subclass `json:"subclass"` | |||
| // optional programming interface | |||
| ProgrammingInterface *pcidb.ProgrammingInterface `json:"programming_interface"` | |||
| // Topology node that the graphics card is affined to. Will be nil if the | |||
There was a problem hiding this comment.
yeah, copy/paste strikes again :)
| // NewWithContext returns a pointer to an Info struct that contains information about | ||
| // the NUMA topology on the host system. Use this function when you want to consume | ||
| // the topology package from another package (e.g. pci, gpu) | ||
| func NewWithContext(ctx *context.Context) (*Info, error) { |
|
hi Jay! We can merge this PR (pending me addressing your comments :) ) with the caveat that |
We want to expose the NUMA locality of the PCI devices, much like we already do for GPU devices. This is very important for high-end, high-performance devices (NICs, storage controllers). To enable testing, we update the snapshot with another one captured with more PCI device informations. See: jaypipes#224 Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
pci-expose-numa-node
branch
from
783de03 to
6a1e32f
Compare
|
And btw, after some trial/errors, #224 reached a form I'm comfortable with, and requires just a minor followup now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to expose the NUMA locality of the PCI devices,
much like we already do for GPU devices.
This is very important for high-end, high-performance devices
(NICs, storage controllers).
To enable testing, we update the snapshot with another one
captured with more PCI device informations.
See: #224
Signed-off-by: Francesco Romani [email protected]