pkg: net: report backing device address #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP because we need tests; to enable tests, we need to have a ghw snapshot in the source tree; I will provide it with a PR soon enough. |
|
To move forward, we need first to move forward on #224 |
ffromani
changed the title
|
This PR is a precondition to solve #92 |
jaypipes
requested changes
Feb 11, 2021
Report the backing device address - currently PCI only - in the network interface data. This allows the client code to fetch the device information using the specific package, for example `pkg/pci`. The PCIAddress field is non-nil only if the backing device is connected through a PCI bus. Non-PCI devices (e.g. USB network interface are not yet supported). Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
net-backing-device-address
branch
from
617636e to
13f3f64
Compare
jaypipes
approved these changes
Feb 11, 2021
|
@fromanirh for a future PR, feel free to update the README.md to list this new PCIAddress field. |
Sure thing! #226 (actually I should have done this earlier :\ ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report the backing device address - currently PCI only -
in the network interface data.
This allows the client code to fetch the device information using
the specific package, for example
pkg/pci.We prefer to add the address, and not a pointer to the relevant
backing device object, the make the net module less coupled with
the other hardware modules.
Signed-off-by: Francesco Romani [email protected]