Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] ci build and dockerfile changes #25148

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

Ruturaj4
Copy link
Collaborator

  1. Install system GCC libraries
  2. Remove docker image
  3. apt update

Created from: ROCm#161

@Ruturaj4
Copy link
Collaborator Author

@superbobry could you please approve? thanks!

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Nov 27, 2024
@Ruturaj4
Copy link
Collaborator Author

@superbobry @dfm can someone merge please?

@dfm
Copy link
Collaborator

dfm commented Dec 10, 2024

It looks like there was a merge conflict when this was submitted internally and then it must have gotten lost in the shuffle. Thanks for the ping! @Ruturaj4 — Can you rebase, and then I'll get this merged?

@dfm dfm self-assigned this Dec 10, 2024
@Ruturaj4 Ruturaj4 force-pushed the ci_install_sys_libs-upstream branch from f8e2385 to bfcace4 Compare December 19, 2024 15:03
@Ruturaj4
Copy link
Collaborator Author

@dfm Just rebased! Could you please merge! thanks.

@copybara-service copybara-service bot merged commit 25713f9 into jax-ml:main Dec 19, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants