-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point to the conda-forge jaxlib wheels in the JAX readme. #11888
Conversation
Yes. Two comments:
I will suggest some edits to address both points in a bit (or can do so in a later PR) |
README.md
Outdated
### Conda installation | ||
|
||
There is a community-supported Conda build of `jaxlib`. See the | ||
[jaxlib conda-forge](https://github.com/conda-forge/jaxlib-feedstock#installing-jaxlib) | ||
project for installation instructions. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Conda installation | |
There is a community-supported Conda build of `jaxlib`. See the | |
[jaxlib conda-forge](https://github.com/conda-forge/jaxlib-feedstock#installing-jaxlib) | |
project for installation instructions. | |
### Conda installation | |
There is a community-supported Conda builds of `jaxlib` and `jax`, which are driven independently of the JAX team. See the | |
[jaxlib](https://github.com/conda-forge/jaxlib-feedstock#installing-jaxlib) and [jax](https://github.com/conda-forge/jax-feedstock#installing-jax) | |
repositories for installation instructions. Note that, the conda-forge project redistributes CUDA and CuDNN; as such, there is no need to install them beforehand. If you would like to install the CUDA-enabled builds of `jaxlib`, follow the instructions in the [Tips & tricks](https://conda-forge.org/docs/user/tipsandtricks.html#installing-cuda-enabled-packages-like-tensorflow-and-pytorch) section of the conda-forge website. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I don't know if this is the correct formatting... it looks weird; feel free to discard now and I can submit a PR later if needed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I incorporated a number of your suggestions. By the way, I found out that it is actually not sufficient to let conda
install CUDA for you. JAX needs ptxas
, which isn't distributed. So you must install at least the ptxas
binary yourself. Everything else necessary is in the conda
builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we get ptxas under conda-forge too. Could you give me a quick test to investigate this? There was a discussion about this previously in conda-forge. I will try to locate it and see the updates on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, now I remember. I was even part of the discussion:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching the ptxas bit! Crucial!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for a test as we likely won't even catch it as we do have ptxas in the containers we use for building but not in the distributed cudatoolkit --- in the future, we could discuss building an "optimized" container on top of the conda-forge binaries if you'd like, which will be on top of the nvidia containers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ptxas
issue is fixable with a little bit of engineering work on our side (there's a library version of the same thing: libnvptxcompiler_static.a
) or with the agreement of NVidia to allow redistribution of ptxas
. I'll raise it with them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this PTX Compiler Python binding be useful as an alternative to calling ptxas
: https://github.com/rapidsai/ptxcompiler ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do you one better:
Fixes #189