Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add basic weather states #153

Closed

Conversation

LexMonster
Copy link
Contributor

@LexMonster LexMonster commented Oct 28, 2024

Pull Request Description

Adds basic support for weather and different weather conditions. This includes settings and display.

This is a fully fletched new "entity" very similar to how events and their categories work.

  • Adds weather conditions (like categories but for weather states)
  • Adds weather states
  • Display weather states in Agenda and "Day" view
  • Adds a setting to disable displaying

Checklist

  • I have read the contribution guidelines and code of conduct.
  • I have tested the changes locally and they are working as expected.
  • I have added appropriate comments and documentation for the code changes.
  • My code follows the coding style and standards of this project.
  • I have rebased my branch on the latest main (or master) branch.
  • All tests (if applicable) have passed successfully.
  • I have run linters and fixed any issues.
  • I have checked for any potential security issues or vulnerabilities.

Screenshots (if applicable)

image image

Additional Notes

This is just a proposal, I am willing to change anything requested.

I can not seem to understand how the repo is configured with lint/formatting. If there is any info on that I can refactor of course.

#8

@LexMonster LexMonster closed this Nov 13, 2024
@LexMonster
Copy link
Contributor Author

Needs more work with seasons coming in anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant