Solve compatibility issues with scikit>=0.24 #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rfayat Thanks for helping with this. I suspect even this PR is now out of date. Do you have an interest in becoming a co-owner of the package? Are you still using it? |
|
Hi @jasonlaska, indeed as mentioned in #35 the API changed again with v1.0 and this PR is therefore outdated and I'm closing it. Sure I'd be happy to help you manage the package ! I'll work on compatibility with the latest version of scikit (which is supposed to be stable so there shouldn't be further issues) when I'll have a bit of time 😄 |
|
Hi @jasonlaska sorry I was on vacation last week and I missed your invitation to co-own the repository which now has expired... Could you please re-send it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
First of all thanks a lot for implementing these algorithms !
I've taken care of solving issue #29 which came from a change in scikit's code for kmeans with the release of scikit v0.23. As mentioned by @dominikstrb in PR #31, fixing the issue went a little deeper than simply replacing
sklearn.clusters.k_means_bysklearn.clusters._kmeansmainly because_init_centroidsis now a class method ofKMeans(the same issue is for instance mentioned here).In any case, I hope this help ! This is only the second time I contribute to a public repo so I am 100% open to feedback.
Cheers,
Romain F