-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homogeneise risc-v test script with arm-m4 testing #1037
base: main
Are you sure you want to change the base?
Conversation
Still allow to use user-defined assembly checkier binaries to ease development on other distributions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need two files now that arm and risc-v testing are very similar?
|
||
set -e | ||
|
||
DIR=$(mktemp -d jasminXXXXXX) | ||
# User defined assembly checker binary or llvm-mc | ||
# for macos homebrew install : export ASSEMBLY_CHECKER=riscv64-unknown-elf-as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really about macos & homebrew or is it just that you want to use the GNU toolchain rather than the LLVM one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out.
You're right that the point is more about GCC vs LLVM than the OS / distribution (the message should be either changed / removed).
Nonetheless, as far as I am aware, the easiest way to get going with risc-v compilation on a mac-os system is to use the brew recipe: https://formulae.brew.sh/formula/riscv64-elf-gcc, which indeed provides GCC to cross compile for risc-v.
To have llvm compile for risc-v you may need to build it from source.
I would argue for minimizing the base code and keep a single file, also, I would personally benefit from being able to set the assembly checker by export if possible. I'll look into that. |
Problem was:
Solution is: