Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homogeneise risc-v test script with arm-m4 testing #1037

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

clebreto
Copy link
Contributor

@clebreto clebreto commented Feb 3, 2025

Problem was:

  • risc-v test suite script adds additional and unnecessary constraints to the testing suite

Solution is:

  • Remove the constraints while allowing to use user-defined assembly checker binaries to ease development on other distributions / package managers.
  • Document how to set ASSEMBLY_CHECKER and ASSEMBLY_CHECKER_OPTIONS for macos brew.

Still allow to use user-defined assembly checkier binaries to ease
development on other distributions.
@clebreto clebreto requested a review from vbgl February 3, 2025 15:07
@clebreto clebreto marked this pull request as ready for review February 3, 2025 15:07
@clebreto clebreto requested a review from eponier February 3, 2025 15:09
Copy link
Member

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need two files now that arm and risc-v testing are very similar?


set -e

DIR=$(mktemp -d jasminXXXXXX)
# User defined assembly checker binary or llvm-mc
# for macos homebrew install : export ASSEMBLY_CHECKER=riscv64-unknown-elf-as
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really about macos & homebrew or is it just that you want to use the GNU toolchain rather than the LLVM one?

Copy link
Contributor Author

@clebreto clebreto Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out.

You're right that the point is more about GCC vs LLVM than the OS / distribution (the message should be either changed / removed).

Nonetheless, as far as I am aware, the easiest way to get going with risc-v compilation on a mac-os system is to use the brew recipe: https://formulae.brew.sh/formula/riscv64-elf-gcc, which indeed provides GCC to cross compile for risc-v.

To have llvm compile for risc-v you may need to build it from source.

@clebreto
Copy link
Contributor Author

clebreto commented Feb 3, 2025

Do we need two files now that arm and risc-v testing are very similar?

I would argue for minimizing the base code and keep a single file, also, I would personally benefit from being able to set the assembly checker by export if possible.

I'll look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants