Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

feat: Offer S2I scripts as an alternative #3

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

tumido
Copy link
Member

@tumido tumido commented Oct 24, 2022

Allow users option to use S2I. These are sample S2I scripts which work well together with ubi8/9 nodejs builder images.

Based on S2I scripts from Operate First: https://github.com/operate-first/service-catalog/tree/main/.s2i/bin

Related to: helm-backstage#7

Signed-off-by: Tomas Coufal <[email protected]>
Co-authored-by: SamoKopecky <[email protected]>
Co-authored-by: Michal Drla <[email protected]>
@raffaelespazzoli
Copy link
Collaborator

can you add documentation on how you would use s2i?

@tumido
Copy link
Member Author

tumido commented Nov 2, 2022

Updated, @raffaelespazzoli please review.

Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sabre1041 sabre1041 merged commit 8e7c379 into janus-idp:main Nov 9, 2022
@sabre1041 sabre1041 mentioned this pull request Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants