-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init #192
base: master
Are you sure you want to change the base?
Init #192
Conversation
|
||
private final int order; | ||
|
||
private Group(int order) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not very nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets try implement factories in a couple of plugins, like: https://ci.jenkins.io/job/Core/job/jenkins/view/change-requests/job/PR-10009/2/pipeline-graph/
|
||
/** | ||
* Displays the duration of the given run, or, if the run has completed, shows the total time it took to execute | ||
* @implNote This will render Jelly, hence the fields return null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this is needed, no null fields anymore
* @implNote This will render Jelly, hence the fields return null |
maybe
* @implNote This will render Jelly, hence the fields return null | |
* @implNote This renders Jelly |
See JENKINS-XXXXX.
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
: