Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gemfile version numbers #1035

Merged

Conversation

softins
Copy link
Member

@softins softins commented Sep 6, 2024

Short description of changes

Update package versions in Gemfile and Gemfile.lock to current latest versions. Also add webrick, which now needs to be installed separately for live serving.

Context: Fixes an issue? Related issues

Necessities discovered while installing on Ubuntu 24

Status of this Pull Request

Ready

What is missing until this pull request can be merged?

Nothing

Does this need translation?
No

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I'm sure that this Pull Request goes to the correct branch

@softins softins marked this pull request as draft September 6, 2024 16:47
@softins softins force-pushed the update-gemfile-versions branch from f86b4b8 to 6b7535d Compare September 6, 2024 17:23
@softins softins marked this pull request as ready for review September 6, 2024 17:29
@softins softins requested a review from gilgongo September 6, 2024 17:34
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to run jekyll build before i could run jekyll serve on my Debian 12.7 machine. But it seems ok.

@ann0see ann0see added this to the Release 3.11.0 milestone Sep 6, 2024
@@ -70,14 +95,54 @@ GEM
rb-fsevent (0.11.2)
rb-inotify (0.11.1)
ffi (~> 1.0)
rexml (3.3.4)
strscan
rexml (3.3.7)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we don't need to merge #1008 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. When this has been merged, dependabot should close that PR. If it doesn't do so automatically, it can be triggered with a dependabot rebase comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, #1008 is raised against release. This PR is raised against next-release. My understanding is when the next-release branch gets moved/merged to release, #1008 won't be needed any more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. @softins is correct.

@softins
Copy link
Member Author

softins commented Sep 6, 2024

I needed to run jekyll build before i could run jekyll serve on my Debian 12.7 machine. But it seems ok.

I didn't find that necessary. I've been running bundle exec jekyll serve without ever having done a jekyll build. See my steps at https://gist.github.com/softins/3ede94214eaec206d31d6fe659705cc2#file-jekyll-ubuntu-md

@ann0see
Copy link
Member

ann0see commented Sep 6, 2024

I didn't run bundle exec <command>. So it may be different. Or just Debian vs Ubuntu.

@ann0see ann0see merged commit fb235e8 into jamulussoftware:next-release Sep 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants