Skip to content

Commit

Permalink
core/service: drop unneeded unit_add_to_gc_queue()
Browse files Browse the repository at this point in the history
Follow-up for a1d3157
and 6ac62d6

With the aforementioned commits, unit_release_resources()
is dispatched in a dedicated queue, and Service.n_keep_fd_store
has been dropped, hence the comment is outdated. Moreover,
the unit is added to GC queue in unit_notify() already.
No other unit types do this in corresponding _enter_dead()
functions, nor does Service need it anymore.
  • Loading branch information
YHNdnzj committed Feb 12, 2025
1 parent 468e872 commit 818315a
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/core/service.c
Original file line number Diff line number Diff line change
Expand Up @@ -2152,10 +2152,6 @@ static void service_enter_dead(Service *s, ServiceResult f, bool allow_restart)
(void) unit_set_debug_invocation(UNIT(s), false);
}

/* The new state is in effect, let's decrease the fd store ref counter again. Let's also re-add us to the GC
* queue, so that the fd store is possibly gc'ed again */
unit_add_to_gc_queue(UNIT(s));

/* The next restart might not be a manual stop, hence reset the flag indicating manual stops */
s->forbid_restart = false;

Expand Down

0 comments on commit 818315a

Please sign in to comment.