[pull] main from libsdl-org:main #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Calling `X11_XIfEvent` after the X11 connection errored out can result in hangs.
This PR updates the geometry renderer example such that the `color` values of `vertices[3]` are set correctly in `SDL_AppIterate`.
mask is created but never deleted if SetWindowRgn() fails. This may lead to resource leaks.
The LED hint was getting registered for SDL_HINT_JOYSTICK_ENHANCED_REPORTS instead of SDL_HINT_JOYSTICK_HIDAPI_PS5_PLAYER_LED, which results in a use-after-free followed by a crash.
PipeWire now requires the correct struct type is used, otherwise it will fail to compile. Reference: https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/188d920733f0791413d3386e5536ee7377f71b2f Fixes: #12224
…eeded, the currentVertexBuffer would be reset to zero and thus we'd leave it pointing to an in-use VB that would get overwritten on the next present before the vkQueueSubmit occurred.
The Wayland keyboard repeat code assumes that if we have a certain timeout then we'll wait at least that long, and generate a key repeat event on timeout. If we wait a shorter time, we won't generate a key repeat event and then return 0, even if we were supposed to wait indefinitely. Fixes https://github.com/libsdl-org/SDL/issues/12239
…lscreen A window may have been maximized by dragging it to the top of another display, in which case the floating position may be out-of-date. If the window is being restored to maximized, and the maximized and floating position are on different displays, try to center the window on the maximized display for restoration, which mimics native Windows behavior.
[ci skip]
… for proper functionality
This will be needed later, after libdecor passes through toplevel bounds, but for now it causes a crash in the Cairo plugin, so remove it.
This adds quite a bit of code size to SDL for a niche use-case. This is easily handled in the application instead.
This is the output format of stb_image for image decoding, so let's avoid a texture format conversion where possible. Also standardized SDL_PIXELFORMAT_ARGB8888 as the default texture format for all renderers.
A similar change was made for Vulkan in a036aed
Code used wcslen that return number of characters, but D3D12 debug layer uses bytes + wide chars
It turns out the mapping we include doesn't work for real controllers, and they're using a generic chipset and generic name and can't be generally distinguished from other controllers. See #8644 for details.
The X backend had the same issue, so both Cocoa and X can be handled in the same location.
It can be null if the desktop mode is set early during initial display enumeration.
This is true if fullscreen is pending or currently active. This is a better check in SDL_SetDesktopDisplayMode() because a fullscreen mode may be pending and complete asynchronously and the window hasn't been set to fullscreen yet.
[ci skip]
We don't need to include the logical offset, it's already included in the viewport. Fixes #12454
Fixed X11 message boxes failing to initialize, because the proper X Logical Font Description could not be found
People are adding present calls while rendering to render targets, not understanding that this doesn't make sense, and wondering why they get flicker on some systems. If there are programs that relied on the previous behavior we can add a hint to control this. Fixes #12432
Openbox doesn't send size events when entering fullscreen, so they must be synthesized. This is not desirable on any other window manager, as it can break fullscreen positioning on multi-monitor configurations.
This reverts commit 0c8ddc1. The real bug here is that XWayland isn't sending us a display disconnected event, which will be handled in the next commit.
Also updated X11_CheckDisplaysMoved() to handle multiple X11 screens Fixes #12462
[ci skip]
[ci skip]
On Ubuntu 24.04 running XWayland, XTestFakeMotionEvent() appears to succeed but doesn't actually move the cursor, even if the cursor is hidden.
[ci skip]
…e events External windows often handle their own events, and SDL implicitly processing events during synchronization can be unexpected and cause issues. For requests that don't change the window state beyond size or position, use the legacy synchronization method that synthesizes events from the window attributes without processing events.
Also added texture addressing mode support to the PSP and Vita renderers (untested) Fixes #12461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )