Pull Request? #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and the x and y velocities). This was done to remove the raw numbers from the code.
…e quantities actually are.
… and placed them in there.
…pdate_boids function.
…te boids function
…laces in the code.
…s again. Also, I slightly changed the indention inside update_boids
…the various relevant functions from the main body there as methods.
…nes to try and make the code a little more readable.
…e the one in boids.py
… this should be an "internal" property of the boid I think it will make the code more readable this way.
…function in boids.py.
… update_boid function in the main code to use the boid class rather than the functions it currently uses.
…hat made them conditional of distance.
…reviously. I also changed the animate function to work with this new update_boids. While this is a rather large refactor there wasn't a step in the middle where the code as a whole entirely worked.
… very very large delta. There may be a problem with my code which is making the velocity of the boids far too high.
…lass methods in case that is the source of the problem.
…sure what is wrong. Velocity must be updating by the wrong amount but it's not obvious which section is giving an error since it all runs.
…eing process incorrect from here.
…ined the wrong way round, adding velocity in the wrong direction!
…update_boids it didn't run all of boids. Not only that, I also changed the way the loops over the match_speed method work since this also meant the regression test failed.
… at the origin and 1,1 respectively.
…hecks whether the velocity of one of the boids is properly changed by another boid.
…rly with two boids.
…ance method works as expected.
…istance function works as expected.
… corresponding .yml
…the correct range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure if we should do a pull request so I did one just to be on the safe side.