Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added List<String> UriInfo#getMatchedResourceTemplates() #1245

Closed
wants to merge 4 commits into from
Closed

Added List<String> UriInfo#getMatchedResourceTemplates() #1245

wants to merge 4 commits into from

Conversation

jansupol
Copy link
Contributor

No description provided.

@jansupol
Copy link
Contributor Author

Alternative to #1236 with a List return type

@jansupol jansupol mentioned this pull request Mar 25, 2024
Merged
jim-krueger
jim-krueger previously approved these changes Mar 26, 2024
View reviewed changes
@jansupol
Javadoc fix
34f14f9 
Signed-off-by: jansupol <[email protected]>
@jansupol jansupol added this to the 4.0 milestone Mar 26, 2024
spericas
spericas approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jansupol
Copy link
Contributor Author

@jamezp Do you prefer #1236 over this one?

@jamezp
Copy link
Contributor

jamezp commented Mar 27, 2024

@jamezp Do you prefer #1236 over this one?

I do prefer #1236 mainly because it seems to be what the OTel users are looking for. I'll admit it's easier for RESTEasy too, but we could make it work with a collection as well if we needed.

@jansupol
Copy link
Contributor Author

To me, this one looks more universal, but perhaps it is unnecessary. We can go with the simpler one.

@jim-krueger
Copy link
Contributor

FWIW: This was the response from issue originator (Andrew) on this:

... For our purposes, a String is good, if it was a list we'd want to concatenate it back into a single string.

@jansupol
Copy link
Contributor Author

Closing this in favor of #1236

@jansupol jansupol closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamezp jamezp jamezp left review comments

@jim-krueger jim-krueger jim-krueger approved these changes

@spericas spericas spericas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jansupol @jamezp @jim-krueger @spericas