-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the TCK generation , remove old shell script (tckbundle.sh) #1224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jaxrs-tck/docs/userguide/src/main/jbake/content/attributes.conf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a PR for main branch as well.
Will it be better to re-target this PR to main branch. |
@alwin-joseph I think we should just re-target it to main |
The base branch was changed.
7c5319b
to
49987a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this question should block the PR and maybe it's been brought up before, but is there any reason we don't simply just generate the TCK docs for each build instead of keeping the generate static content in the source repository?
If you mean the generation of jaxrs-tck/docs/userguide , IMO keeping it separate can reduce the overall build time of other modules(spec, api,tck, examples). Maybe this can be discussed further if the current build process can be improved. |
FWIW when I built it locally it didn't take much time at all. I would love to discuss that build process as a whole really as well :) |
Describe the changes:
mvn -f jaxrs-tck/docs/userguide
cd jaxrs-tck; mvn clean install
cd jaxrs-tck; mvn clean install -PEPL