Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the TCK generation , remove old shell script (tckbundle.sh) #1224

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

alwin-joseph
Copy link
Contributor

Describe the changes:

  • Moved jaxrs-tck-docs as jaxrs-tck/docs
  • To generate userguide : mvn -f jaxrs-tck/docs/userguide
  • To build TCK jar and zip bundle (with EFTL) :
    cd jaxrs-tck; mvn clean install
  • To build TCK jar and zip bundle (with EPL) :
    cd jaxrs-tck; mvn clean install -PEPL

spericas
spericas previously approved these changes Feb 21, 2024
Copy link
Contributor

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jim-krueger
jim-krueger previously approved these changes Feb 23, 2024
Copy link
Contributor

@jim-krueger jim-krueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a PR for main branch as well.

jansupol
jansupol previously approved these changes Feb 24, 2024
@alwin-joseph
Copy link
Contributor Author

Needs a PR for main branch as well.

Will it be better to re-target this PR to main branch.
I can create another PR for main branch if that is more convenient. In this case, please help merge this PR.

@spericas
Copy link
Contributor

@alwin-joseph I think we should just re-target it to main

@alwin-joseph alwin-joseph changed the base branch from release-3.2 to main March 13, 2024 14:42
@alwin-joseph alwin-joseph dismissed stale reviews from jansupol, jim-krueger, and spericas March 13, 2024 14:42

The base branch was changed.

Copy link
Contributor

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this question should block the PR and maybe it's been brought up before, but is there any reason we don't simply just generate the TCK docs for each build instead of keeping the generate static content in the source repository?

jaxrs-tck/pom.xml Show resolved Hide resolved
@alwin-joseph
Copy link
Contributor Author

I don't think this question should block the PR and maybe it's been brought up before, but is there any reason we don't simply just generate the TCK docs for each build instead of keeping the generate static content in the source repository?

If you mean the generation of jaxrs-tck/docs/userguide , IMO keeping it separate can reduce the overall build time of other modules(spec, api,tck, examples).

Maybe this can be discussed further if the current build process can be improved.

@jamezp
Copy link
Contributor

jamezp commented Mar 14, 2024

I don't think this question should block the PR and maybe it's been brought up before, but is there any reason we don't simply just generate the TCK docs for each build instead of keeping the generate static content in the source repository?

If you mean the generation of jaxrs-tck/docs/userguide , IMO keeping it separate can reduce the overall build time of other modules(spec, api,tck, examples).

Maybe this can be discussed further if the current build process can be improved.

FWIW when I built it locally it didn't take much time at all. I would love to discuss that build process as a whole really as well :)

@spericas spericas merged commit 5676ac8 into jakartaee:main Mar 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants