Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.0: Deprecate h:form prependId #1991

Merged
merged 1 commit into from
Jan 8, 2025
Merged

5.0: Deprecate h:form prependId #1991

merged 1 commit into from
Jan 8, 2025

Conversation

BalusC
Copy link
Member

@BalusC BalusC commented Dec 21, 2024

@BalusC BalusC requested review from arjantijms and mnriem December 21, 2024 14:32
@BalusC BalusC changed the title Deprecate h:form prependId 5.0: Deprecate h:form prependId Dec 21, 2024
mnriem
mnriem approved these changes Jan 1, 2025
View reviewed changes
Copy link
Contributor

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I have no problem deprecating this I do think this should be mentioned on the mailing list as a heads up. What do you think?

arjantijms
arjantijms approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@arjantijms arjantijms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strongly agree, thanks!

@arjantijms arjantijms merged commit ab296a6 into 5.0 Jan 8, 2025
1 check passed
@arjantijms arjantijms deleted the faces_issue_1972_deprecate_UIForm_prependId branch January 8, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnriem mnriem mnriem approved these changes

@arjantijms arjantijms arjantijms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BalusC @arjantijms @mnriem