add missing lyxblogger.py and do with style tag in img(as to lyXHTML) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In additon, fix bug when upload images:if you resize the image in Lyx, then lyXHML will generate image tag as <img style="xxx%;" src="..."/>,so we should stipe style when upload the generated html content
jackdesert
reviewed
Oct 18, 2016
| @@ -0,0 +1,919 @@ | |||
| #! /usr/bin/env python | |||
There was a problem hiding this comment.
INSTALL/lyxblogger.py is a generated file. Can you say why you are adding it to source control?
There was a problem hiding this comment.
When I run: python setup.py install, it said:
running install
running build
running build_py
file lyxblogger.py (for module lyxblogger) not found
So I put lyxblogger.py to INSTALL directory, any problem?
jackdesert
reviewed
Oct 18, 2016
src/LyxBlog/term.py
Outdated
| # GNU/Linux, Mac, and unidentified OS's call xterm | ||
| return('xterm -T "LyXBlogger" -fg gold -bg black -fn 10x20 -e python %s %s %s ') | ||
| # GNU/Linux, Mac, and unidentified OS's call rxvt | ||
| return('rxvt -T "LyXBlogger" -fg gold -bg black -fn 10x20 -e python %s %s %s ') |
There was a problem hiding this comment.
I am running a flavor of ubuntu, and I notice that rxvt is not installed on my machine by default.
There was a problem hiding this comment.
Oh, I'm sorry, maybe rxvt is not the default terminal of ubuntu.
But, the old xterm is really not friendly to Chinese like characters, and rxvt is better. How to resolve this situation? maybe an install option to setup terminal type?
This reverts commit 7b98f5a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In additon, fix bug when upload images:if you resize the image in Lyx, then lyXHML will generate
,so we should stipe style when upload the generated
image tag as
html content