Added support for testing on postgres using docker #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhegarty
force-pushed
the
pg-test-for-issue-102
branch
from
418a607 to
264d379
Compare
matthewhegarty
force-pushed
the
pg-test-for-issue-102
branch
from
264d379 to
533acf2
Compare
izimobil
requested changes
Aug 18, 2021
docs/example-app.rst
Outdated
| Postgres | ||
| ######## | ||
|
|
||
| You can use Postgres as the source database. To do this, you will need to have `Docker <https://docker.com/>`_ installed. |
There was a problem hiding this comment.
You will need to have => You can use
Docker not being the only option to install postgres :)
There was a problem hiding this comment.
Have updated the wording.
| @@ -0,0 +1,25 @@ | |||
| # Generated by Django 3.2.5 on 2021-07-20 21:32 | |||
There was a problem hiding this comment.
Is this migration really needed ? I don't see any changes to the models of example app but maybe I'm missing something...
There was a problem hiding this comment.
It adds the 'ordering' (no idea why it didn't appear in the initial migration). I can remove it if preferred - probably doesn't make any difference in the test app.
1st migration:
options={
'verbose_name': 'Album',
'verbose_name_plural': 'Albums',
},
new migration:
migrations.AlterModelOptions(
name='album',
options={'ordering': ['name'], 'verbose_name': 'Album', 'verbose_name_plural': 'Albums'},
),
izimobil
approved these changes
Aug 18, 2021
|
Merged, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
docker-compose.ymlfile and supporting scripts to optionally test on Postgres.This was added to test #102.
Incidentally, running
makemigrationsadded a new migration for the example app.No changes to functional code