Voevent 2.1 pr after RFC

[BaptisteCecconi]

No description provided.

[gmantele]

This PullRequest contains a lot of modifications that I did not look into details. But here are my three comments:

1. A change request: a conflict has not been properly resolved ; it has left a trace with the famous <<<< HEAD string.
2. I can generate the PDF, but not the SVG images inserted into the PDF, although I have Inkscape installed on my machine. Is it normal?
3. The RFC is not yet finished. A lot of WG (including DAL....shame on me) and IG have not yet commented or voted. Maybe you would want to wait for all comments before merging this PR...

[BaptisteCecconi]

This PullRequest contains a lot of modifications that I did not look into details. But here are my three comments:

1. A change request: a conflict has not been properly resolved ; it has left a trace with the famous <<<< HEAD string.

Thanks, I missed this one. This is fixed in 7bc253e

2. I can generate the PDF, but not the SVG images inserted into the PDF, although I have Inkscape installed on my machine. Is it normal?

No idea. Note that I updated the ivoatex submodule. Could this be linked?

3. The RFC is not yet finished. A lot of WG (including DAL....shame on me) and IG have not yet commented or voted. Maybe you would want to wait for all comments before merging this PR...

I included most of the comments from @mcdittmar and @msdemlei, when I considered them relevant, and when @msdemlei didn't say he was willing to propose a PR. To ease the process of @msdemlei to propose his updates, could we merge this PR and then start from the new content?

[gmantele]

Looks fine to me.

[gmantele]

This PullRequest contains a lot of modifications that I did not look into details. But here are my three comments:

1. A change request: a conflict has not been properly resolved ; it has left a trace with the famous <<<< HEAD string.

Thanks, I missed this one. This is fixed in 7bc253e

You're welcome 😉

2. I can generate the PDF, but not the SVG images inserted into the PDF, although I have Inkscape installed on my machine. Is it normal?

No idea. Note that I updated the ivoatex submodule. Could this be linked?

No idea either. I've just make this comment as a warning...something to take a look at, otherwise the version on IVOA-Doc repo will not look good.

3. The RFC is not yet finished. A lot of WG (including DAL....shame on me) and IG have not yet commented or voted. Maybe you would want to wait for all comments before merging this PR...

I included most of the comments from @mcdittmar and @msdemlei, when I considered them relevant, and when @msdemlei didn't say he was willing to propose a PR. To ease the process of @msdemlei to propose his updates, could we merge this PR and then start from the new content?

Fine with me. Again, it was just a general comment, nothing blocking for me 😉

[gmantele]

I let you merge whenever you think it is the right moment.

[msdemlei]

On Wed, Jan 15, 2025 at 07:14:42AM -0800, Baptiste Cecconi wrote: > 2. I can generate the PDF, but not the SVG images inserted into the PDF, although I have Inkscape installed on my machine. Is it normal? No idea. Note that I updated the ivoatex submodule. Could this be linked?

You mean the role diagram? What happens if you try? Updating the submodule is almost always a good thing. I keep trying to make the submodules thing work better (does make update work for you?). If nothing else helps, try (cd ivoatex; git checkout master; git pull) If SVG generation still does not work, I'd be interested in the error messages. Note, however, that the preferred svg -> pdf renderer now is now rsvg-convert from librsvg2-bin, which is a lot more compact and is less volatile in the CLI than inkscape is.

I included most of the comments from @mcdittmar and @msdemlei, when I considered them relevant, and when @msdemlei didn't say he was willing to propose a PR. To ease the process of @msdemlei to propose his updates, could we merge this PR and then start from the new content?

Yes, I'd prefer that.

[gmantele]

On Wed, Jan 15, 2025 at 07:14:42AM -0800, Baptiste Cecconi wrote: > 2. I can generate the PDF, but not the SVG images inserted into the PDF, although I have Inkscape installed on my machine. Is it normal? No idea. Note that I updated the ivoatex submodule. Could this be linked?
You mean the role diagram? What happens if you try? Updating the submodule is almost always a good thing. I keep trying to make the submodules thing work better (does make update work for you?). If nothing else helps, try (cd ivoatex; git checkout master; git pull) If SVG generation still does not work, I'd be interested in the error messages. Note, however, that the preferred svg -> pdf renderer now is now rsvg-convert from librsvg2-bin, which is a lot more compact and is less volatile in the CLI than inkscape is.

My fault: I forgot to recursively clone this repo resulting in no ivoatex at all. Besides, rsvg-convert was not installed on this machine (my comment about Inkscape is because of the generated fallback PDF stating that no Inkscape was found although it was on my machine ; maybe this error message should be updated). It seems to work nicely now. Thanks for forcing me to look into this one more time. It should probably be noted that make clean does not remove role-diagram.pdf ; I had to remove it manually after my first attempt without rsvg-convert in order to have it re-generated properly.

It is all good for me now.