Export CMake libraries with aliases for easy use #675
Closed
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows bdwgc to be included in a CMake build using `add_subdirectory`, `FetchContent`, or similar. It then relies on this CMake policy to ensure the library is found in any `target_link_libraries` usage: https://cmake.org/cmake/help/latest/policy/CMP0028.html Without the alias, `target_link_libraries` will not be able to find `gc`, `gccpp`, etc. More info here: https://stackoverflow.com/a/77211132
|
LGTM. Will be merged in a day. |
ivmai
pushed a commit
that referenced
this pull request
Nov 1, 2024
PR #675 (bdwgc). This allows bdwgc to be included in a cmake build using `add_subdirectory`, `FetchContent`, or similar. It then relies on the CMake CMP0028 policy to ensure the library is found in any `target_link_libraries` usage. Without the alias, `target_link_libraries` will not be able to find `gc`, `gccpp`, etc. * CMakeLists.txt (add_library): Specify alias for gc. * CMakeLists.txt [enable_cplusplus] (add_library): Specify alias for gccpp. * CMakeLists.txt [enable_cplusplus && enable_throw_bad_alloc_library] (add_library): Specify alias for gctba. * CMakeLists.txt [build_cord] (add_library): Specify alias for cord.
|
Merged. |
|
Thanks, Ivan! |
ivmai
pushed a commit
that referenced
this pull request
Dec 27, 2024
(a cherry-pick of commit 1b04347 from 'master') PR #675 (bdwgc). This allows bdwgc to be included in a cmake build using `add_subdirectory`, `FetchContent`, or similar. It then relies on the CMake CMP0028 policy to ensure the library is found in any `target_link_libraries` usage. Without the alias, `target_link_libraries` will not be able to find `gc`, `gccpp`, etc. * CMakeLists.txt (add_library): Specify alias for gc. * CMakeLists.txt [enable_cplusplus] (add_library): Specify alias for gccpp. * CMakeLists.txt [enable_cplusplus && enable_throw_bad_alloc_library] (add_library): Specify alias for gctba. * CMakeLists.txt [build_cord] (add_library): Specify alias for cord.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows bdwgc to be included in a CMake build using
add_subdirectory,FetchContent, or similar. It then relies on this CMake policy to ensure the library is found in anytarget_link_librariesusage: https://cmake.org/cmake/help/latest/policy/CMP0028.htmlWithout the alias,
target_link_librarieswill not be able to findgc,gccpp, etc.More info here: https://stackoverflow.com/a/77211132