Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/kotlin transition #195

Open
wants to merge 2 commits into
base: dev/2.4.0
Choose a base branch
from

Conversation

yatiksihag01
Copy link

This PR extends #190 which was closed due to change in base branch. This PR also solved all the unexpected behaviour mentioned here.

…d DataUsageViewModel and UsageDataHelperImpl for single responsibility, optimized UsageDataAdapter with AsyncListDiffer and click listeners in AppDataUsageFragment, replaced AsyncTask with Kotlin coroutines, and added debug suffix for debug package.
@itsdrnoob itsdrnoob changed the base branch from release/2.3.2 to dev/2.4.0 September 8, 2023 02:50
@itsdrnoob
Copy link
Owner

Great, most of the previous issues were addressed but I've still noticed some issues.

  • The System apps list gets refreshed upon opening and requires additional refresh to update values on session change or after refreshing the main list. Presumably due to the shift of data loading to AppDataUsageFragment.
  • Due to the shift, the data is refreshed only on navigating to the fragment, adding to an increase in loading time.
  • I've also noticed that the data is refreshed on every navigation, causing a lag/delay while navigating to the fragment.

Let me know what you think.

@yatiksihag01
Copy link
Author

requires additional refresh to update values on session change or after refreshing the main list

Hi @itsdrnoob , can you please explain a bit about first issue?

@itsdrnoob
Copy link
Owner

Hi @itsdrnoob , can you please explain a bit about first issue?

Sure. So basically both user app list as well as system apps list has to be refreshed on events like manual refresh in AppDataUsageFragment and session/type filter change, so that if opened, the up-to-date data is readily available in SystemDataUsageFragment. This was done by accessing the AppDataUsageFragment.mSystemList.

Also, here are some other details I've observed

  • On changing the filter from a session/type which is empty, the loading shimmer is not shown from there after.
  • The background time seems inaccurate. It will sometimes show the same value as screen time (when it's different) or shows 0.
  • Another minute detail, on changing the session, the recyclerView position stays the same (should scroll to the top).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants