SPLIME

[krystophny]

Depends on: #17 (not logically, but let's merge #17 first)

Introduces generic tensor-product-spline routines based on existing code. Semantics are taken from scipy.interpolate.

[krystophny]

@pazathoth now that one is also finished.

Refactor: Clean up CMake for faster builds (don't check for HDF5 three times) and readability
Feature: Add generic 1D and 2D spline driver routines and tests

[pazathoth]

Note that I didn't repeat possibilities for improvement when they are anyway nearby, e.g. they apply analogously to 1D and 2D splines.

[krystophny]

@pazathoth that should be fine now. Please do a quick check and then we merge. I merged #17 already, since the code changes there appeared also here (branch based on the other one) and there were no comments.

[krystophny]

@pazathoth I added the last changes. I still ask for your formal acknowledgement in the code review to check the messages.

In the future, if we just have minor revisions at the end, let's handle it like in a journal paper and the PR owner can just merge after minor last fixes, OK?

Regarding rebase and merge, let's try the rebase strategy for now, since PRs should always be small (< 1 week work) and independent, so the danger of conflicts is low. Is that fine for you too?

See https://github.blog/changelog/2022-02-03-more-ways-to-keep-your-pull-request-branch-up-to-date/ for browser-based rebase. Use Pull-Down menu in the big green "Update" box and select "Rebase".

[pazathoth]

@pazathoth I added the last changes. I still ask for your formal acknowledgement in the code review to check the messages.

In the future, if we just have minor revisions at the end, let's handle it like in a journal paper and the PR owner can just merge after minor last fixes, OK?

Regarding rebase and merge, let's try the rebase strategy for now, since PRs should always be small (< 1 week work) and independent, so the danger of conflicts is low. Is that fine for you too?

See https://github.blog/changelog/2022-02-03-more-ways-to-keep-your-pull-request-branch-up-to-date/ for browser-based rebase. Use Pull-Down menu in the big green "Update" box and select "Rebase".

Yes, that's alright with me. Then I will repeat comments at every occurrence, e.g. with replacement of real(8), so that nothing is missed. The rebase I will try with Jonatan on #18.

[krystophny]

Thank you, I merge then!