feat(driver): standalone driver context #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
added
C-enhancement
refcell
requested changes
Sep 3, 2024
crates/rollup/src/driver/cursor.rs
Outdated
Comment on lines
69
to
73
| /// When the L1 undergoes a reorg, we need to reset the cursor to the fork block. | ||
| /// This is the last L1 block for which we have a corresponding L2 block in the cache. | ||
| /// | ||
| /// Returns the (L2 block info, L1 origin block info) tuple for the new cursor state. | ||
| pub fn reset(&mut self, fork_block: u64) -> (BlockInfo, BlockInfo) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
If I'm understanding this right, the way this reset works is it's trying to get the (L1 origin, L2 block) pair prior to the reorg and then start derivation for the next l2 blocks from there.
merklefruit
force-pushed
the
nico/feat/l1-listener
branch
from
15221cd to
b5386e3
Compare
refcell
approved these changes
Sep 5, 2024
merklefruit
force-pushed
the
nico/feat/l1-listener
branch
from
b5386e3 to
b92ccc5
Compare
This was referenced Sep 7, 2024
This PR fixes all dependency-related compile errors, mainly due to changes to location of types in different crates. It also pins `op-alloy`, `kona` and `superchain` deps allow us to work on a stable trunk until the type migration is done. Also removed `ssz_rs` in favor of `ethereum_ssz`, as with the new alloy version we can't access it from `private::`. - closes #83 Stack: - #77 - 👉 #85 - #86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Introduces a
StandaloneDriverimplementation that uses an L1 rpc url to fetch block updates.Meta