Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(net): Refactor GossipDriver #47

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Aug 27, 2024

Description

Warning

Stacked ontop of #46, merge after #46.

Refactors GossipDriver specific logic out of the top-level NetworkDriver and into the GossipDriver.

@refcell refcell added C-refactor A-net Area: Network crate labels Aug 27, 2024
@refcell refcell requested a review from merklefruit August 27, 2024 14:40
@refcell refcell self-assigned this Aug 27, 2024
@refcell refcell changed the title fix(net): Allow custom noise configuration feat(net): Refactor GossipDriver Aug 27, 2024
Copy link
Collaborator

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@refcell refcell requested a review from Rjected August 27, 2024 15:30
Base automatically changed from rf/fix/expose-noise-config to main August 27, 2024 16:10
@refcell refcell merged commit a8d2c32 into main Aug 27, 2024
11 checks passed
@refcell refcell deleted the rf/feat/refactor-net-builder branch August 27, 2024 16:14
refcell added a commit that referenced this pull request Aug 27, 2024
### Description

> [!WARNING]
>
> Stacked ontop of #47.

Adds unit tests to the `NetworkDriverBuilder`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-net Area: Network crate C-refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants