-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rollup): create rollup pipeline from kona_derive
#31
Merged
merklefruit
merged 11 commits into
ithacaxyz:main
from
merklefruit:nico/feat/new-pipeline
Aug 26, 2024
Merged
feat(rollup): create rollup pipeline from kona_derive
#31
merklefruit
merged 11 commits into
ithacaxyz:main
from
merklefruit:nico/feat/new-pipeline
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22a2cc0
to
7ee5988
Compare
7ee5988
to
00f9f79
Compare
refcell
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chore: typo chore: rm useless clippy rules chore: small type coercion fix: commit tip before breaking loop feat(hera): rebased on bin/ location change chore: rename kona -> hera in cli
4d99825
to
39ee1cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an utility to create a
kona_derive::DerivationPipeline
implementation suitable for the rollup node.In particular, I tried to keep only the providers as generic, because the actual stage implementations will
most likely be the same for the exex and the standalone mode.
addresses part of #8.