Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump reth to 1.2.0 #144

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: bump reth to 1.2.0 #144

wants to merge 3 commits into from

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Feb 26, 2025

Bumps reth to 1.2 and alloy to 0.11

@Rjected Rjected force-pushed the dan/bump-reth-1.2 branch 2 times, most recently from 2d09d7c to dd6119b Compare February 26, 2025 02:10
Comment on lines 250 to 256
type PayloadBuilder = reth_optimism_payload_builder::OpPayloadBuilder<
Pool,
Node::Provider,
OdysseyEvmConfig,
PrimitivesTy<Node::Types>,
Txs,
>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this just got significantly easier on main

@Rjected Rjected force-pushed the dan/bump-reth-1.2 branch 4 times, most recently from 1a201a5 to 13443c1 Compare February 27, 2025 04:59
@Rjected Rjected marked this pull request as ready for review February 27, 2025 05:00
@Rjected Rjected requested a review from onbjerg as a code owner February 27, 2025 05:00
@Rjected Rjected requested a review from mattsse February 27, 2025 05:00
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

most of the isthmus features are not tested and possible that this is causing some issues e.g. isthmus now has different engine API and the isthmus consensus checks are also not fully tested via op hive+kurtosis yet

but we'll see

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onbjerg do we still need this relay binary?

@@ -77,7 +78,7 @@ async fn test_wallet_api() -> Result<(), Box<dyn std::error::Error>> {

// Create and sign authorization
let auth = Authorization {
chain_id: provider.get_chain_id().await?,
chain_id: U256::from(provider.get_chain_id().await?),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes u256 chain ids 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants