-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump reth to 1.2.0 #144
base: main
Are you sure you want to change the base?
Conversation
2d09d7c
to
dd6119b
Compare
crates/node/src/node.rs
Outdated
type PayloadBuilder = reth_optimism_payload_builder::OpPayloadBuilder< | ||
Pool, | ||
Node::Provider, | ||
OdysseyEvmConfig, | ||
PrimitivesTy<Node::Types>, | ||
Txs, | ||
>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this just got significantly easier on main
1a201a5
to
13443c1
Compare
13443c1
to
fdaa810
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
most of the isthmus features are not tested and possible that this is causing some issues e.g. isthmus now has different engine API and the isthmus consensus checks are also not fully tested via op hive+kurtosis yet
but we'll see
bin/relay/src/main.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@onbjerg do we still need this relay binary?
@@ -77,7 +78,7 @@ async fn test_wallet_api() -> Result<(), Box<dyn std::error::Error>> { | |||
|
|||
// Create and sign authorization | |||
let auth = Authorization { | |||
chain_id: provider.get_chain_id().await?, | |||
chain_id: U256::from(provider.get_chain_id().await?), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes u256 chain ids 👍
79d2dc2
to
5f4003d
Compare
5f4003d
to
00e5f87
Compare
Bumps reth to 1.2 and alloy to 0.11