Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): improve integration tests configuration #119

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

CreeptoGengar
Copy link
Contributor

Description

This PR updates the integration tests workflow configuration to follow modern best practices and improve test output visibility.

Changes in .github/workflows/integration.yml:

  • Added --profile ci flag to nextest configuration for better CI integration and consistency
  • Replaced deprecated --no-tests=warn flag with modern --no-capture flag for better test output visibility
  • Updated re-actors/alls-green action from release/v1 to specific version v1.2.2 for improved stability

Why

  • Improves test output readability in CI environment
  • Updates deprecated test configuration to modern standards
  • Pins action version for better reproducibility
  • Makes integration tests configuration consistent with other workflows

Testing

  • Integration tests workflow has been tested and works as expected
  • Test outputs are now more verbose and easier to debug
  • No functional changes to the tests themselves

@@ -37,8 +37,9 @@ jobs:
cargo nextest run \
--locked \
--workspace \
--profile ci \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, don't see a ci profile in cargo.toml

@CreeptoGengar
Copy link
Contributor Author

@mattsse made an update

Copy link
Contributor

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is ok

@onbjerg onbjerg merged commit f4fa6b0 into ithacaxyz:main Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants