♻️ Added Test for EntryPoint & Fix Issues #29
Conversation
There was a problem hiding this comment.
this is pretty good although i'd love if we also had tests where the signature isnt just rsv since that only works for the eoa root key as far as i understand. i.e. if we had tests for a secp256k1 key that doesnt recover to address(eoa). same with p256 and p256webauthn (although i guess the last one is pretty hard to achieve in solidity?)
Added P256 & secp256k1 separate testcases. While p256webauthn is hard to test in solidity working on it. |
* Added accounts nonce in entryPoint * Storage of failuer err msg * 2d Nonce in delegation * Fix Nonce Issue in Entrypoint * Fix OOG tests * T * T * Tidy the 63/64 check * ♻️ Normify EntryPoint (#32) --------- Co-authored-by: Vectorized <[email protected]>
|
I think let's merge this to main for now. We can revert if something goes wrong. After this is merged, I'll make the PR for the new upgradable proxy. |
Summary:
Fix Issue:
Entrypoint._verify()signature length