Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzz / invariant tests #13

Open
jenpaff opened this issue Jan 31, 2025 · 0 comments · Fixed by #29
Open

Fuzz / invariant tests #13

jenpaff opened this issue Jan 31, 2025 · 0 comments · Fixed by #29
Assignees
Milestone

Comments

@jenpaff
Copy link
Contributor

jenpaff commented Jan 31, 2025

Description

We want to make sure we have enough tests and coverage on major functionality.

Example test cases:

Test on keys+spend permissions:

  • User can add permissions with expiry to a session key (All the scope/spend-perms-related flows), ensure session key cannot transact after it expires, ensure session key cannot transact when revoked
  • User can add and remove new admin and session keys (All the add/remove key flows), ensure only admin key can add new admin keys, ensure account has at least 1 admin key
  • User can sign up with a new key and generate a session key in the same call & start signing transactions with session key

ERC20 flow:

  • User can have their gas sponsored by paying in ERC20, ensure transaction is validated (signature)
  • Gas estimation edge cases: what happens when user pays too much/too little
  • paymentRecipient receives fees (covering all edge cases here)

Batch calls:

  • User can batch multiple calls (e.g. mint + tansfer)

Upgrade Proxy/Impl flow:

  • User can upgrade implementation to use new functionality

Gas cost comparison for each flow (compared to 4337)

Tests on:

  • GuardedExectuor
  • Delegation
@jenpaff jenpaff assigned atarpara and unassigned Vectorized Feb 9, 2025
@jenpaff jenpaff linked a pull request Feb 13, 2025 that will close this issue
5 tasks
@jenpaff jenpaff reopened this Feb 24, 2025
@jenpaff jenpaff added this to the v1.0 milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants