Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[casr-cluster] Add cluster updating support #183

Merged
merged 35 commits into from
Feb 2, 2024
Merged

[casr-cluster] Add cluster updating support #183

merged 35 commits into from
Feb 2, 2024
+1,096 −110

Conversation

hkctkuy
Copy link
Member

@hkctkuy hkctkuy commented Dec 7, 2023

No description provided.

@hkctkuy hkctkuy marked this pull request as draft December 7, 2023 09:28
@hkctkuy hkctkuy linked an issue Dec 7, 2023 that may be closed by this pull request
[casr-cluster] Support cluster merging #177
Closed
@hkctkuy hkctkuy force-pushed the accumulate_reports branch 2 times, most recently from 66e5bd3 to 076c726 Compare December 7, 2023 10:18
@hkctkuy hkctkuy marked this pull request as ready for review December 7, 2023 15:13
@hkctkuy hkctkuy force-pushed the accumulate_reports branch from b5d5297 to 89300a7 Compare December 7, 2023 15:17
@hkctkuy hkctkuy changed the title [casr-cluster] Add update cluster poc [casr-cluster] Add cluster updating support Dec 7, 2023
@hkctkuy hkctkuy force-pushed the accumulate_reports branch from cc22f30 to a5b58a8 Compare December 8, 2023 13:59
@codecov Codecov
Copy link

codecov bot commented Dec 8, 2023 •
edited
Loading

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (74623d5) 62.81% compared to head (227d4fd) 64.28%.
Report is 1 commits behind head on master.

Files Patch % Lines
casr/src/bin/casr-cluster.rs 85.00% 36 Missing ⚠️
casr/src/util.rs 82.02% 16 Missing ⚠️
libcasr/src/cluster.rs 97.09% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   62.81%   64.28%   +1.46%     
==========================================
  Files          31       32       +1     
  Lines        7296     7713     +417     
==========================================
+ Hits         4583     4958     +375     
- Misses       2713     2755      +42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hkctkuy hkctkuy force-pushed the accumulate_reports branch 2 times, most recently from bdec678 to b80750d Compare December 8, 2023 21:25
@hkctkuy hkctkuy force-pushed the accumulate_reports branch from b80750d to 0098632 Compare December 9, 2023 20:40
Avgor46
Avgor46 reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@Avgor46 Avgor46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we need to describe all techniques (like inner/outer) in docs later

casr/src/util.rs Outdated Show resolved Hide resolved
casr/src/util.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Outdated Show resolved Hide resolved
Avgor46
Avgor46 reviewed Dec 13, 2023
View reviewed changes
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Outdated Show resolved Hide resolved
Avgor46
Avgor46 reviewed Dec 13, 2023
View reviewed changes
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
Avgor46
Avgor46 reviewed Dec 29, 2023
View reviewed changes
casr/src/bin/casr-cluster.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
SweetVishnya
SweetVishnya requested changes Dec 29, 2023
View reviewed changes
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
casr/tests/tests.rs Show resolved Hide resolved
@hkctkuy hkctkuy force-pushed the accumulate_reports branch from 530a464 to cefb37b Compare January 16, 2024 14:07
@hkctkuy hkctkuy force-pushed the accumulate_reports branch from cefb37b to d3cec56 Compare January 18, 2024 10:39
@hkctkuy hkctkuy force-pushed the accumulate_reports branch from 0509307 to 37637b2 Compare January 26, 2024 09:45
SweetVishnya
SweetVishnya requested changes Jan 26, 2024
View reviewed changes
docs/usage.md Outdated Show resolved Hide resolved
casr/src/util.rs Outdated Show resolved Hide resolved
casr/src/util.rs Outdated Show resolved Hide resolved
@hkctkuy hkctkuy requested a review from Avgor46 January 26, 2024 21:31
Avgor46
Avgor46 reviewed Jan 29, 2024
View reviewed changes
casr/src/bin/casr-cluster.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Show resolved Hide resolved
PaDarochek
PaDarochek reviewed Feb 1, 2024
View reviewed changes
casr/src/bin/casr-cluster.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Outdated Show resolved Hide resolved
SweetVishnya
SweetVishnya requested changes Feb 1, 2024
View reviewed changes
casr/src/util.rs Outdated Show resolved Hide resolved
casr/src/util.rs Show resolved Hide resolved
casr/src/util.rs Outdated Show resolved Hide resolved
casr/src/util.rs Outdated Show resolved Hide resolved
casr/src/util.rs Outdated Show resolved Hide resolved
libcasr/src/cluster.rs Show resolved Hide resolved
libcasr/src/cluster.rs Show resolved Hide resolved
libcasr/src/cluster.rs Outdated Show resolved Hide resolved
libcasr/src/cluster.rs Outdated Show resolved Hide resolved
libcasr/src/cluster.rs Show resolved Hide resolved
PaDarochek
PaDarochek reviewed Feb 2, 2024
View reviewed changes
libcasr/src/cluster.rs Outdated Show resolved Hide resolved
casr/tests/tests.rs Show resolved Hide resolved
@hkctkuy hkctkuy force-pushed the accumulate_reports branch from cedb1d4 to 4457e95 Compare February 2, 2024 10:47
@SweetVishnya SweetVishnya merged commit df9eecf into ispras:master Feb 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaDarochek PaDarochek PaDarochek left review comments

@Avgor46 Avgor46 Avgor46 approved these changes

@SweetVishnya SweetVishnya SweetVishnya approved these changes

@anfedotoff anfedotoff Awaiting requested review from anfedotoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[casr-cluster] Support cluster merging
4 participants
@hkctkuy @SweetVishnya @Avgor46 @PaDarochek