Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[casr-cluster] Add dedup by crashline for each cluster #170

Merged
merged 7 commits into from
Nov 6, 2023

Conversation

hkctkuy
Copy link
Member

@hkctkuy hkctkuy commented Nov 1, 2023

No description provided.

@hkctkuy hkctkuy linked an issue Nov 1, 2023 that may be closed by this pull request
docs/usage.md Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Outdated Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
@hkctkuy hkctkuy requested a review from Avgor46 November 2, 2023 09:23
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ca3ba4f) 61.86% compared to head (59503a8) 62.27%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   61.86%   62.27%   +0.41%     
==========================================
  Files          30       30              
  Lines        6947     7012      +65     
==========================================
+ Hits         4298     4367      +69     
+ Misses       2649     2645       -4     
Files Coverage Δ
libcasr/src/report.rs 56.55% <100.00%> (ø)
libcasr/src/stacktrace.rs 96.63% <94.73%> (-0.20%) ⬇️
casr/src/bin/casr-cluster.rs 84.93% <94.44%> (+1.15%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Outdated Show resolved Hide resolved
casr/tests/tests.rs Show resolved Hide resolved
@hkctkuy hkctkuy requested a review from anfedotoff November 2, 2023 14:11
@anfedotoff
Copy link
Collaborator

We also need to test this option manually on some real world examples.

@SweetVishnya
Copy link
Collaborator

aarch64 and riscv ci is red

docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
libcasr/src/stacktrace.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-cluster.rs Outdated Show resolved Hide resolved
docs/usage.md Show resolved Hide resolved
@hkctkuy hkctkuy force-pushed the unique_crashline branch 2 times, most recently from 71daa1f to 0bbea7a Compare November 3, 2023 15:12
@anfedotoff anfedotoff merged commit dd9f727 into ispras:master Nov 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep only reports with unique crashline in cluster
4 participants