Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first commit biascorrection #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

first commit biascorrection #2

wants to merge 2 commits into from

Conversation

erwinlambert
Copy link
Collaborator

First code for the bias correction method in T-S space from Naughten et al.

The biascorr/src/ folder contains relatively clean code and general (plotting) functions, the biascorr/notebooks/ folder contains more messy code to plot examples.

(See if this works:)
Closes #1

@erwinlambert erwinlambert linked an issue Dec 4, 2024 that may be closed by this pull request
@xylar xylar self-requested a review December 4, 2024 15:10
@xylar xylar self-assigned this Dec 4, 2024
@xylar
Copy link
Member

xylar commented Dec 4, 2024

@erwinlambert, can you provide me with the following that would help me review this?

What packages do I need to run the scripts and notebook?

Is there some way for me to usefully run the code? If not, that's fine. I can just inspect it.

@erwinlambert
Copy link
Collaborator Author

@xylar , I was actually just writing up an email to suggest Nico to review the code, as we'll need to exchange and collaborate mostly.

Still, if you do want to review, the list of packages is:

  • xarray
  • numpy
  • matplotlib
  • cmocean
  • whatever is necessary to run notebooks (ipython?)

However, the code won't run without the data I'm afraid, which is a whole bunch of large cmip output files

@xylar
Copy link
Member

xylar commented Dec 4, 2024

@erwinlambert, I just invited @nicolasjourdain to join the the repo. I think it's best for him to review. This looks good to me at a quick glance.

@xylar xylar removed their request for review December 4, 2024 16:26
@xylar
Copy link
Member

xylar commented Dec 5, 2024

@erwinlambert, I think this looks good. The code is clean and will be easy to incorporate into a package in the near future so it's easier to share code between parts of our project.

@erwinlambert
Copy link
Collaborator Author

Great, I will see whether @nicolasjourdain wants to have a look as well. Otherwise I'll merge the code as a starting point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bias correction
2 participants