Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation: Do not set field when no result is available #140

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

dbaston
Copy link
Member

@dbaston dbaston commented Aug 20, 2024

References #138

@dbaston dbaston force-pushed the gh-138 branch 2 times, most recently from 141e606 to 7f000c6 Compare August 21, 2024 01:28
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.91%. Comparing base (9af0c0b) to head (c3cc593).
Report is 1 commits behind head on master.

Files Patch % Lines
python/src/exactextract/writer.py 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   90.98%   90.91%   -0.07%     
==========================================
  Files          85       85              
  Lines        6312     6309       -3     
  Branches      622      621       -1     
==========================================
- Hits         5743     5736       -7     
- Misses        537      541       +4     
  Partials       32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbaston dbaston merged commit fe2191d into isciences:master Aug 21, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant