Make role usable on RedHat based distros #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snyssen
added a commit
to snyssen/infra-snyssen.be
that referenced
this pull request
Oct 19, 2022
A PR is waiting to merged at ironicbadger/ansible-role-snapraid#11 Once merged, revert this commit and depends directly on source role instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were made to be able to install and configure snapraid on a Fedora system, but it should also work on other distro using dnf and .rpm packages.
When run under a RedHat based system, the role will make use of the changes proposed by my previous pull request on docker-snapraid to build the package and install it using dnf. Since that PR was not merged yet, I added a new parameter that allows the user to change the repository used to build the package. This way, I could point it to https://github.com/snyssen/docker-snapraid.git where I have the updated code allowing the .rpm builds.
I also took this opportunity to add a missing
tlsflag for the SMTP config of snapraid-runner