Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#78] Restore build compatibility with iRODS 4.3.1 packages #79

Merged
merged 1 commit into from
Mar 1, 2024
Merged

[#78] Restore build compatibility with iRODS 4.3.1 packages #79

merged 1 commit into from
Mar 1, 2024

Conversation

SwooshyCueb
Copy link
Member

Addresses #78

korydraughn
korydraughn reviewed Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Does it compile against 4.3.1 packages?

@trel
Copy link
Member

trel commented Mar 1, 2024

so readable and clean. we must be from the future....

@SwooshyCueb
Copy link
Member Author

Looks good. Does it compile against 4.3.1 packages?

Yes indeed.

korydraughn
korydraughn approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

alanking
alanking approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# it when ready

@SwooshyCueb
Copy link
Member Author

#'d

@alanking alanking merged commit fd647e8 into irods:4-3-stable Mar 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korydraughn korydraughn korydraughn approved these changes

@alanking alanking alanking approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SwooshyCueb @trel @korydraughn @alanking