Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[irods/irods#7531] remove EXACT argument from find_package(IRODS call (4-3-stable) #77

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

SwooshyCueb
Copy link
Member

In service of irods/irods#7531

Merge irods/irods#7536 before merging this.

@korydraughn
Copy link
Collaborator

Will approve once we get a new release of this plugin for 4.3.1 done.

As of right now, 4-3-stable needs a couple tweaks before that can happen. The tweaks are related to 55bb2b0.

@SwooshyCueb SwooshyCueb marked this pull request as draft March 1, 2024 18:46
@SwooshyCueb SwooshyCueb changed the title [irods/irods#7531] bump irods version requirement and remove exact requirement (4-3-stable) [irods/irods#7531] remove EXACT argument from find_package(IRODS call (4-3-stable) Mar 1, 2024
@SwooshyCueb SwooshyCueb marked this pull request as ready for review March 1, 2024 19:03
@SwooshyCueb
Copy link
Member Author

I've made this PR 4.3.1-compatible, so it shouldn't interfere with the release.

Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# it when ready

@alanking
Copy link
Contributor

alanking commented Mar 1, 2024

Will merge after #76

...unless @korydraughn has objections. I defer.

Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pound it.

@alanking
Copy link
Contributor

alanking commented Mar 1, 2024

Please disregard my last comment. I referenced the wrong PR. :)

@SwooshyCueb
Copy link
Member Author

#'d

@alanking alanking merged commit 33207e1 into irods:4-3-stable Mar 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants