Preventing imeta mod bypass #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is to address #58? |
FifthPotato
force-pushed
the
no-mod-bypass.m
branch
from
7786d8c to
0aadb75
Compare
|
good so far - let's get a couple tests in today. |
korydraughn
reviewed
Feb 16, 2024
|
All we need now are the tests and we're good to go. |
FifthPotato
force-pushed
the
no-mod-bypass.m
branch
from
0aadb75 to
7afcd4f
Compare
|
Added test, and force-pushed because I forgot to update main on my repo after my last PR. |
trel
reviewed
Feb 19, 2024
korydraughn
reviewed
Feb 19, 2024
korydraughn
reviewed
Feb 19, 2024
|
Don't forget to mark comments resolved as you complete them. |
korydraughn
reviewed
Feb 19, 2024
korydraughn
reviewed
Feb 19, 2024
|
Tests pass. |
|
Good. Please squash to taste, no #'s |
FifthPotato
force-pushed
the
no-mod-bypass.m
branch
from
95e5a99 to
99a0937
Compare
|
Squashed |
|
Let's adjust the commit message so that it isn't specific to Looking at the test again, it appears we're missing tests which prove I'll write up an issue for that. We can add tests in a later PR. |
FifthPotato
force-pushed
the
no-mod-bypass.m
branch
from
99a0937 to
ba1f6d4
Compare
|
Amended! |
korydraughn
approved these changes
Feb 19, 2024
FifthPotato
force-pushed
the
no-mod-bypass.m
branch
from
ba1f6d4 to
6401264
Compare
|
Octothorpe'd |
|
Please cherry-pick to the 4-3-stable branch, no #'s. |
|
@FifthPotato ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to work so far. Need to do a bit more research to figure out if there are any other cases I missed.
Need to write tests, too.