-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[irods/irods#6251,irods/irods#6256] find_package for fmt and spdlog #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pound it.
9edae97
to
4fc6374
Compare
#'d |
Created 4-3-stable branch based on 78ef388. We may need to create a branch for development against 4.3.1's build system (thinking about the open PRs and possible other development work going on). Thoughts? |
@alanking I'm assuming that's because the externals are changing? @SwooshyCueb Do these changes depend on new externals packages? Are those new externals packages incompatible with 4.3.1? |
Not these. The changes in #256 and #257 do though.
Yes. All externals explicitly built against libc++ have moved into different subfolders, clang and clang-runtime have updated, and spdlog now has a shared library. |
Right, just depends on whether we are okay with releasing while building against unreleased dev and/or runtime packages (if I'm understanding everything correctly). This is pre-1.0, so... maybe okay? |
Y'know what, it doesn't really matter. I think I got confused and assumed the fmt find module was something we made. Carry on. |
I just confirmed tip of main for this repo no longer compiles with 4.3.1 packages and that's fine. We can create a new branch for 4.3.1 development when that time comes. The SHA to branch from is 0720f71 (according to @SwooshyCueb). |
Thinking about it more, let's go ahead and create a branch for 4.3.1 development. @MartinFlores751's OIDC work will need to be available for 4.3.1 once it's complete. |
In service of irods/irods#6251
In service of irods/irods#6256
Once this is merged, a 4-3-stable branch should be created.