[#281] Fix tiering out objects with 'select' in name (main) #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using lowercase 'select' rather than 'SELECT' in GenQuery1 is a known workaround for an issue with the historical parser for dealing with queries that deal with the word 'select'. All internal queries in this plugin have been converted to use lowercase letters for all GenQuery syntax. Also, any instance which was touched and was using boost::format has been changed to use fmt::format. And updated README to use lowercase 'select' in example queries, as well.
|
#'d, mergin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #281
Cherry-picked from #329