Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Github run numbered in release candidate version #487

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sogartar
Copy link
Contributor

@sogartar sogartar commented Feb 10, 2025

We can't make multiple different versions for the same day.

With this change the release candidates will have a version of the form
3.2.0rc20250205-0
3.2.0rc20250205-1
...
instead of just 3.2.0rc20250205.

@sogartar sogartar force-pushed the users/sogartar/add-gh-run-num-to-rc-version branch from 74bdff3 to 8a76301 Compare February 10, 2025 18:20
We can't make multiple different versions for the same day.

With this change the release candidates will have a version of the form
3.2.0rc20250205.0
3.2.0rc20250205.1
...
instead of just 3.2.0rc20250205.

Signed-off-by: Boian Petkantchin <[email protected]>
@sogartar sogartar force-pushed the users/sogartar/add-gh-run-num-to-rc-version branch from 8a76301 to c597295 Compare February 10, 2025 18:35
@sogartar
Copy link
Contributor Author

This is the same of a reverted change #458.

I have verified that the workflow passes fine.
I don't see the upload at https://iree.dev/pip-release-links.html.

@sogartar sogartar requested a review from ScottTodd February 10, 2025 18:48
@ScottTodd
Copy link
Member

I have verified that the workflow passes fine.

Thanks! The version shows up as iree_turbine-3.2.0rc20250210.post73 though. Was that intentional?

See the documentation at https://packaging.python.org/en/latest/discussions/versioning/.

I'm also still not sure we really need this extra suffix given the extra complexity.

I don't see the upload at https://iree.dev/pip-release-links.html.

That index is updated by an action in iree-org/iree, that runs when the IREE docs are updated or an IREE release is completed. The workflow can also be triggered manually.
https://github.com/iree-org/iree/blob/624a9fae4f8dd03becfaae69110411c84c4ed6e8/.github/workflows/publish_website.yml#L67-L82

@ScottTodd
Copy link
Member

You can also test in your fork while still iterating. The test run in this repository pushed the iree_turbine-3.2.0rc20250210.post73-py3-none-any.whl package to https://github.com/iree-org/iree-turbine/releases/tag/dev-wheels. We can either keep that or delete it since "dev wheels" and nightly releases are best-effort and may occasionally do weird things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants