[TKW] CI: Install GPU deps in separate step #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Butygin <[email protected]>
ScottTodd
approved these changes
Jan 10, 2025
| @@ -63,24 +63,26 @@ jobs: | |||
| run: | | |||
| pytest -n 4 --capture=tee-sys -vv ./tests/kernel/wave/ | |||
|
|
|||
| - name: Test TKW runtime related stack on amdgpu | |||
| - name: Install GPU deps | |||
| if: "contains(matrix.os, 'amdgpu') && !cancelled()" | |||
| run: | | |||
| pip install --no-compile -r pytorch-rocm-requirements.txt | |||
There was a problem hiding this comment.
We should probably be working within a venv, especially on persistent self-hosted runners 🤔
There was a problem hiding this comment.
I thought we already do, but yeah, I can look into it
There was a problem hiding this comment.
Sample PR: nod-ai/shark-ai#640
There was a problem hiding this comment.
BTW, as an potential alternative I was using setup-miniconda action in the past https://github.com/numba/numba-mlir/blob/main/.github/workflows/build.yml#L52 and was quite happy with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.