Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load pins from iree-requirements.txt in setup.py. #21

Closed
wants to merge 5 commits into from

Conversation

ScottTodd
Copy link
Member

Without this, pip installs require the unqualified iree-compiler package.
With this, pip installs require the iree-compiler>=[version pin] package (note that get_version_spec here is inserting the >=, even if the requirements file has ==)

This helps for https://github.com/nod-ai/sharktank/tree/main?tab=readme-ov-file#install-development-packages with these instructions:

# Clone and install editable iree-turbine dep in deps/
pip install -f https://iree.dev/pip-release-links.html --src deps \
  -e "git+https://github.com/iree-org/iree-turbine.git#egg=shark-turbine"

@ScottTodd ScottTodd marked this pull request as draft May 20, 2024 19:33
Comment on lines +1 to 3
--find-links https://iree.dev/pip-release-links.html
iree-compiler==20240514.893
iree-runtime==20240514.893
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to make this work without either

A) adding --find-links https://iree.dev/pip-release-links.html to all install commands for iree-turbine
B) only pinning to versions here that are published to pypi (https://pypi.org/project/iree-compiler/#history)

@ScottTodd
Copy link
Member Author

Closing this since it's stale.

@ScottTodd ScottTodd closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant