Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky repo verify #10743

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

test: fix flaky repo verify #10743

wants to merge 1 commit into from

Conversation

lidel
Copy link
Member

@lidel lidel commented Mar 5, 2025 •
edited
Loading

it seems verify not always notices file was broken, this fix performs explicit flush and assumes CI uses filesystem with lazy flush or some other unknown behavior

@lidel lidel added the skip/changelog This change does NOT require a changelog entry label Mar 5, 2025
@lidel lidel force-pushed the fix-flaky-verify-test branch from 3aed24a to 4978ade Compare March 5, 2025 20:41
@lidel lidel added the need/analysis Needs further analysis before proceeding label Mar 5, 2025
@lidel
test: fix flaky repo verify
262f43f 
it seems verify not always notices file was broken, this fix performs
explicit flush and assumes CI uses filesystem with lazy flush or some
other unknown behavior
@lidel lidel force-pushed the fix-flaky-verify-test branch from 4978ade to 262f43f Compare March 5, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
need/analysis Needs further analysis before proceeding skip/changelog This change does NOT require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lidel