This repository was archived by the owner on Aug 11, 2021. It is now read-only.
online -> exchange #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorb
reviewed
Jul 4, 2017
| @@ -27,7 +27,7 @@ class BlockService { | |||
| * @param {Bitswap} bitswap | |||
| * @returns {void} | |||
| */ | |||
| goOnline (bitswap) { | |||
| setExchange (bitswap) { | |||
There was a problem hiding this comment.
The @param note above should probably change to be {Exchange} exchange rather than hardcoded bitswap.
On another note, we should probably add some lightweight checks that the expected functions exists on the object that gets passed in, to prevent scenarios when you set an exchange then call put and get a error about that the function is undefined, we can fail as early as when setting the exchange, with a more friendly error.
daviddias
approved these changes
Jul 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dropping the "online" concept, migrating to setting, unsetting and having an exchange instead.