fix(peers): chrome regression and update ipfs-geoip to v9.2 #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
?format=raw does not benefit from origin isolation, bu switching to raw IP we use path gateway and return payload immediatelly + avoid issue with chrome upgrading to https://
lidel
changed the title
lidel
commented
Feb 19, 2025
Comment on lines
+237
to
+239
| // Normalize Gateway URLS: | ||
| // switch localhost to raw IP to avoid subdomain redirect AND avoid Chrome forcing https:// on such redirect | ||
| gatewayUrls = (Array.isArray(gatewayUrls) ? gatewayUrls : [gatewayUrls]).map(url => url.replace(/localhost:(\d+)/, '127.0.0.1:$1')) |
There was a problem hiding this comment.
ℹ️ At some point Chrome started normalizing HTTP 301 to use https:// instead of http://, even if the origin is localhost. This broke Flags on Peers screen, but we did not notice because most of flags were locally cached in IndexDB and was not immediately obvious it stopped working.
@SgtPooki (just FYI) this PR includes a localized fix for flags on Peers screen but may be useful to know about the bug if it surfaces elsewhere.
ipfs-gui-bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
## [4.5.0](v4.4.2...v4.5.0) (2025-02-25) CID `bafybeiata4qg7xjtwgor6r5dw63jjxyouenyromrrb4lrewxrlvav7gzgi` --- ### Features * add QR Code to ShareModal ([#2320](#2320)) ([5dbccfd](5dbccfd)) ### Bug Fixes * add hint about basic http auth for rpc ([#2338](#2338)) ([7d00889](7d00889)) * **ci:** cluster pinning with timeout and retry ([#2321](#2321)) ([9007e98](9007e98)) * **ci:** typo in ci.yml ([7fbb51b](7fbb51b)) * **peers:** chrome regression and update ipfs-geoip to v9.2 ([#2333](#2333)) ([699f735](699f735)) ### Trivial Changes * add console warning ([#2332](#2332)) ([76a0c52](76a0c52)) * **deps:** bump actions/setup-go from 4 to 5 ([#2221](#2221)) ([412b89f](412b89f)) * pull transifex translations ([#2331](#2331)) ([e62b487](e62b487))
|
🎉 This PR is included in version 4.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ipfs-shipyard/ipfs-geoip/releases/tag/v9.2.0 updates Peers screen to use dataset from 2025-02-18.
This fixes most of invalid country flags that suggest libp2p is breaking the speed of light ;-)
https://on localhost redirect) in 0310932