Start addressing the tests

[hacdias]

Ref.: #50

Starting by testing the components directory.

This uses feat/components as base. Can only be merged after #596

[hacdias]

With the current configuration, I'm getting this:

----------|----------|----------|----------|----------|----------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------|----------|----------|----------|----------|----------------|
All files |  Unknown |  Unknown |  Unknown |  Unknown |                |
----------|----------|----------|----------|----------|----------------|

@victorbjelkholm do you think you could help with this? nyc doesn't seem to be working correctly. I added the configuration to package.json and the instabul plugin to Babel.

Never mind Victor 😄 Although, I'd like to know if it is possible to integrate aegir here (for testing and coverage publishing).

[victorb]

I think you should start with setting up tests with spectron/acceptance testing. Main idea is to just make sure the core UI functionality works. Then you can start adding unit tests for making sure every detail is working. About coverage, we still working on making sure the secret management in Jenkins is stable and secure. So not gonna do that from jenkins just yet.

Another point, in general you should avoid having files with big and small letters, as you'll hit confusing errors when you name some file HelloWorld.md and on the OS you're developing you can load it as helloworld.js but it won't work on others (or vice-versa). It's easier to always have lower-case naming and use underscore instead.

[hacdias]

I think you should start with setting up tests with spectron/acceptance testing. Main idea is to just make sure the core UI functionality works.

I'd like to do that but it isn't simply working... yet! Our electron is using some pre-compilers for LESS and Babel and I wasn't still able to decipher how to use that with Spectron.

Another point, in general you should avoid having files with big and small letters...

I'm just using CamelCase for files with components to follow React's best practices, but I can change that. Should I?

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (feat/components@28608cd). Click here to learn what that means.
The diff coverage is 8.75%.

@@                Coverage Diff                @@
##             feat/components    #604   +/-   ##
=================================================
  Coverage                   ?   4.29%           
=================================================
  Files                      ?      56           
  Lines                      ?     839           
  Branches                   ?       0           
=================================================
  Hits                       ?      36           
  Misses                     ?     803           
  Partials                   ?       0

Impacted Files	Coverage Δ
src/config.js	0% <ø> (ø)
src/components/MenuOption.js	0% <ø> (ø)
src/panes/Intro.js	0% <ø> (ø)
src/screens/welcome.js	0% <ø> (ø)
src/panes/Loader.js	0% <ø> (ø)
src/components/InfoBlock.js	0% <ø> (ø)
src/components/Button.js	100% <ø> (ø)
src/components/Footer.js	0% <ø> (ø)
src/components/IconButton.js	0% <ø> (ø)
src/components/IconDropdownList.js	0% <ø> (ø)
... and 34 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28608cd...fd444fc. Read the comment docs.

[hacdias]

@victorbjelkholm I'm trying to make this simply start the app and nothing seems to happen. I'll increase the timeout for something like 10 mins and see what happens.

Ref.: electron-userland/electron-compile#178

Edit: same thing. Nothing seems to happen after app.start()

[hacdias]

Many conflicts.

• Fix after Fixes Bunch #596 gets merged.

[hacdias]

This tests got merged on #596. Keep working on #596