Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy current IPFS path for IPNS address #532

Closed
wants to merge 1 commit into from

Conversation

lidel
Copy link
Member

@lidel lidel commented Jul 16, 2018

This PR implements context menu item to get current CID for an IPNS address:

screenshot_6

Closes #508

I am quite sure this needs to be reworded before merging.

@olizilla Any ideas how to label this feature?

@lidel lidel requested a review from olizilla July 16, 2018 15:00
@lidel lidel added the UX label Jul 16, 2018
@olizilla
Copy link
Member

This might be more intuitive if we change it to show the user the information rather than trying to frame it as a set of questions... like:

IPFS Resource loaded via Custom Gateway

URL
http://ipfs.io/ipns/room.guardian

PATH
/ipns/room.guardian

CID
bafybafybafybase32yeahwoo


  • Copy URL
  • Pin CID to local repo

@lidel
Copy link
Member Author

lidel commented Jul 21, 2018

@olizilla something like this?

screenshot_4

I like this direction. Clicking on URL, PATH, CID would select entire thing and copy it to clipboard, so most of menu items could be removed.

Not sure how to represent "IPFS resource loaded via Custom Gateway" – it looks out of place.
Perhaps if we show full URL like this, there is no need for it at all?

@olizilla
Copy link
Member

I think URL in that menu should always show the canonical http url https://ipfs.io/ip*

We could use it to show other address forms too as they become supported... hello ipfs://*

@lidel
Copy link
Member Author

lidel commented Sep 19, 2018

Let's continue brainstorming on this in #587

@lidel lidel closed this Sep 19, 2018
@lidel lidel deleted the feat/copy-ipfs-for-ipns branch September 19, 2018 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants