test: re-enable hamt-test in interop #450
Conversation
| @@ -0,0 +1,147 @@ | |||
| import { decode, type PBLink, type PBNode } from '@ipld/dag-pb' | |||
There was a problem hiding this comment.
all of this was copied over from ipfs-unixfs-exporter
| @@ -4,6 +4,8 @@ import { DoesNotExistError, InvalidParametersError } from '../../errors.js' | |||
| import { addLink } from './add-link.js' | |||
There was a problem hiding this comment.
All of the changes in here are originally from @aschmahmann in #448, except that I copied the contents of ./find-shard-cid.js from ipfs-unixfs-exporter
| const onProgress = sinon.stub() | ||
| const resp = await verifiedFetch('ipfs://bafybeidbclfqleg2uojchspzd4bob56dqetqjsj27gy2cq3klkkgxtpn4i/685.txt', { onProgress }) | ||
| expect(resp).to.be.ok() | ||
| const text = await resp.text() | ||
| const onProgressEvents = onProgress.getCalls().map(call => call.args[0]) | ||
| const walkEvents = onProgressEvents.filter((e) => e.type.includes('unixfs:exporter:walk')) | ||
| const blockGetEvents = onProgressEvents.filter((e) => e.type === 'blocks:get:providers:get') | ||
| expect(blockGetEvents).to.have.length(7) | ||
| expect(walkEvents).to.have.length.lessThanOrEqual(8) |
There was a problem hiding this comment.
note that I re-enabled this test on a branch https://github.com/ipfs/helia/tree/test/re-enable-hamt-on-main and it doesn't seem to fail there (it was only failing locally previously), but the events don't show the issues that are seen in ipfs/service-worker-gateway#19 & ipfs/service-worker-gateway#18.
They both have onProgressEvents.length === 41 (which includes blockstore & verified fetch events), so some event is not being surfaced fully from the walk without the changes here.
| @@ -164,6 +164,7 @@ | |||
| "@libp2p/interface": "^1.1.2", | |||
| "@libp2p/logger": "^4.0.5", | |||
| "@multiformats/murmur3": "^2.1.8", | |||
| "err-code": "^3.0.1", | |||
There was a problem hiding this comment.
Please use CodeError from @libp2p/interface instead of adding err-code
|
Please take a look at #455 - it also re-enables this test but uses the |
|
Closing in favor of #455 |
Based on fix from #448, only including e0f8d5e & 3c40080, and then copying over some code from
ipfs-unixfs-exporterTitle
Description
Re-enables the hamt-sharded test since it's reliably passing before 60 second timeout now (roughly 40seconds on my machine)
Notes & open questions
Until the fix in #448 is sufficient, this should not be merged. We should decide on the proper fix, and utilize this test to ensure things are working as expected.
Change checklist