Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Documentations #170

Closed
wants to merge 8 commits into from
Closed

Update Documentations #170

wants to merge 8 commits into from

Conversation

laurentsenta
Copy link
Contributor

@laurentsenta laurentsenta commented Sep 19, 2023 •
edited
Loading

Contributes to #169

Update documentation

  • Add instructions on how to add your own gateway implementation
  • Document the generation flow
  • Link to the dashboard from this repo's README

surface job URL better and render details

  • what commit of the conformance test suite we ran
  • what commit of the implementation we ran against
  • date when these results are from

Follow-ups

  • Use the definitive domain name

@laurentsenta laurentsenta marked this pull request as draft September 19, 2023 08:33
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023 •
edited
Loading

Results against Kubo master:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
2046 0 0 0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023 •
edited
Loading

Results against Kubo latest:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
2046 0 0 0

@laurentsenta laurentsenta marked this pull request as ready for review September 28, 2023 14:46
galargh
galargh approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me so long to get here :atom: Looks great, thanks for taking care of docs :)

.github/workflows/deploy-pages.yml Outdated
@@ -49,7 +49,7 @@ jobs:
echo "name=${NAME}" >> $GITHUB_OUTPUT
- name: Download json output
id: download-artifact
uses: dawidd6/action-download-artifact@v2 # TODO: pin
uses: dawidd6/action-download-artifact@268677152d06ba59fcec7a7f0b5d961b6ccd7e1e # v2.28.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@laurentsenta laurentsenta mentioned this pull request Nov 20, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galargh galargh galargh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurentsenta @galargh