fix: correct go build error passing #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
fix/correct-go-build-error-passing
branch
3 times, most recently
from
2615e67 to
d9313fc
Compare
lidel
force-pushed
the
fix/correct-go-build-error-passing
branch
from
d9313fc to
a2c2732
Compare
This comment was marked as outdated.
This comment was marked as outdated.
lidel
commented
Jan 31, 2024
Comment on lines
+109
to
+112
| if ! (go build -mod=mod -o "$output" -trimpath "${package}"); then | ||
| warn " go build of $output failed." | ||
| return 1 | ||
| fi |
There was a problem hiding this comment.
ℹ️ error handling here was missing
| @@ -144,7 +145,7 @@ function doBuild() { | |||
|
|
|||
| mkdir -p "$dir" | |||
|
|
|||
| if ! (cd "$build_dir_name" && goBuild "$package" "$goos" "$goarch") > build-log; then | |||
| if ! (cd "$build_dir_name" && goBuild "$package" "$goos" "$goarch") > "$build_dir_name/build-log" 2>&1; then | |||
There was a problem hiding this comment.
ℹ️ why error logs were not created correctly OR were missing stderr
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to Close #673
The meta reason is the entire build pipeline not being written with
set -e, which means every potential error path needs to be manually handled, or it will be ignored.For fix here, I suspect things worked fine until we added
glibc-checkhere, which madego buildno longer be the last command ingoBuild, and ifgo buildfails its code is not the code returned bygoBuild, but we continue to the next command, which may run ok due to no binaries to check 🙃TODO